Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more context to certain errors #158

Merged
merged 1 commit into from
Dec 18, 2023
Merged

add more context to certain errors #158

merged 1 commit into from
Dec 18, 2023

Conversation

bacongobbler
Copy link
Member

@bacongobbler bacongobbler commented Dec 1, 2023 •
edited
Loading

This allows the Spin CLI to receive more contextual errors which helps with debugging.

Old error format:

><> spin deploy
Uploading spin-checklist version 0.1.0 to Fermyon Cloud...
Deploying...
Error: response status code: 404 Not Found

New error format:

><> spin deploy
Uploading spin-checklist version 0.1.0 to Fermyon Cloud...
Deploying...
Error: Unable to add revision: response status code: 404 Not Found

itowlson
itowlson reviewed Dec 3, 2023
View reviewed changes
src/commands/deploy.rs Outdated Show resolved Hide resolved
@bacongobbler bacongobbler merged commit 7c32d40 into fermyon:main Dec 18, 2023
8 checks passed
@bacongobbler bacongobbler deleted the more-context branch December 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bacongobbler @itowlson